-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TypeScript performance of BarPercent.tsx
#11076
fix: TypeScript performance of BarPercent.tsx
#11076
Conversation
@@ -1,10 +1,11 @@ | |||
import { styled } from '@mui/material/styles'; | |||
import { SxProps } from '@mui/system'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is another win for pnpm (#11000). By nature it won't allow imports from a package that are not an explicit dependency.
Here, we are importing from @mui/system
which is not defined in our package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use eslint to prevent imports but having a more solid foundation (a better package manager) would be a better fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By nature it won't allow imports from a package that are not an explicit dependency.
music to my ears
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I believe so. I'll do a follow up PR for this!
BarPercent.tsx
BarPercent.tsx
Coverage Report: β
|
@@ -1,10 +1,11 @@ | |||
import { styled } from '@mui/material/styles'; | |||
import { SxProps } from '@mui/system'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description π
BarPercent.tsx
component ποΈPreview π·
How to test π§ͺ
yarn tsc --generateTrace ./trace --incremental false
and inspect withchrome://tracing
)As an Author I have considered π€